[
https://issues.apache.org/jira/browse/HIVE-26556?focusedWorklogId=817494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-817494
]
ASF GitHub Bot logged work on HIVE-26556:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/22 07:43
Start Date: 17/Oct/22 07:43
Worklog Time Spent: 10m
Work Description: szlta commented on code in PR #3667:
URL: https://github.com/apache/hive/pull/3667#discussion_r996710899
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java:
##########
@@ -137,6 +137,8 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
// Currently ClusteredWriter is used which requires that records are
ordered by partition keys.
// Here we ensure that SortedDynPartitionOptimizer will kick in and do the
sorting.
// TODO: remove once we have both Fanout and ClusteredWriter available:
HIVE-25948
+ HiveConf.setIntVar(configuration,
HiveConf.ConfVars.HIVEOPTSORTDYNAMICPARTITIONTHRESHOLD, 1);
+ HiveConf.setVar(configuration, HiveConf.ConfVars.DYNAMICPARTITIONINGMODE,
"nonstrict");
jobConf.put(HiveConf.ConfVars.HIVEOPTSORTDYNAMICPARTITIONTHRESHOLD.varname,
"1");
jobConf.put(HiveConf.ConfVars.DYNAMICPARTITIONINGMODE.varname,
"nonstrict");
Review Comment:
Do we need to keep the `jobConf.put` invocations here besides `HiveConf.set`
calls?
Issue Time Tracking
-------------------
Worklog Id: (was: 817494)
Time Spent: 2.5h (was: 2h 20m)
> Iceberg: Properties set in HiveIcebergSerde are not propagated to jobconf
> -------------------------------------------------------------------------
>
> Key: HIVE-26556
> URL: https://issues.apache.org/jira/browse/HIVE-26556
> Project: Hive
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-2
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Some hive properties (ex. InputFormatConfig.CASE_SENSITIVE) are not
> propagated to the jobconf. This scenario can be reproduced by running
> TestHiveIcebergSelects#testScanTableCaseInsensitive test method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
