[
https://issues.apache.org/jira/browse/HIVE-13353?focusedWorklogId=818831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818831
]
ASF GitHub Bot logged work on HIVE-13353:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/22 15:04
Start Date: 20/Oct/22 15:04
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3608:
URL: https://github.com/apache/hive/pull/3608#discussion_r1000759228
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsOperation.java:
##########
@@ -68,6 +76,37 @@ public int execute() throws HiveException {
return 0;
}
+ private ShowCompactRequest getShowCompactioRequest(ShowCompactionsDesc desc)
throws MetaException, SemanticException {
+ ShowCompactRequest request = new ShowCompactRequest();
+ if (isBlank(desc.getDbName() )&& isNotBlank(desc.getTbName())) {
+ request.setDbname(SessionState.get().getCurrentDatabase());
+ } else {
+ request.setDbname(desc.getDbName());
+ }
+ if (isNotBlank(desc.getTbName()))
+ request.setTablename(desc.getTbName());
+ if (isNotBlank(desc.getPoolName()))
+ request.setPoolName(desc.getPoolName());
+ if (isNotBlank(desc.getCompactionType()))
+
request.setType(TxnUtils.inputCompactionType2DBType(desc.getCompactionType()));
+ if (isNotBlank(desc.getCompactionStatus()))
+
request.setState(TxnUtils.compactorStateFromInput(desc.getCompactionStatus()));
+ if (isNotEmpty(desc.getPartSpec()))
+ request.setPartitionname(getPartitionName(desc.getPartSpec()));
+ return request;
+ }
+
+ private String getPartitionName(Map<String, String> partitionSpec) throws
SemanticException {
Review Comment:
same method exists in AlterTableUpdateColumnStatistictAnalyzer, could we
move it to utils class?
Issue Time Tracking
-------------------
Worklog Id: (was: 818831)
Time Spent: 7h (was: 6h 50m)
> SHOW COMPACTIONS should support filtering options
> -------------------------------------------------
>
> Key: HIVE-13353
> URL: https://issues.apache.org/jira/browse/HIVE-13353
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 1.3.0, 2.0.0
> Reporter: Eugene Koifman
> Assignee: KIRTI RUGE
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-13353.01.patch
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> Since we now have historical information in SHOW COMPACTIONS the output can
> easily become unwieldy. (e.g. 1000 partitions with 3 lines of history each)
> this is a significant usability issue
> Need to add ability to filter by db/table/partition
> Perhaps would also be useful to filter by status
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
