[
https://issues.apache.org/jira/browse/HIVE-20257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stamatis Zampetakis updated HIVE-20257:
---------------------------------------
Fix Version/s: (was: 4.0.0)
I cleared the fixVersion field since this ticket is not resolved. Please review
this ticket and if the fix is already committed to a specific version please
set the version accordingly and mark the ticket as RESOLVED.
According to the JIRA guidelines
(https://cwiki.apache.org/confluence/display/Hive/HowToContribute) the
fixVersion should be set only when the issue is resolved/closed.
> Improvements to Hive.java
> -------------------------
>
> Key: HIVE-20257
> URL: https://issues.apache.org/jira/browse/HIVE-20257
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 3.0.0, 4.0.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Minor
> Attachments: HIVE-20257.1.patch, HIVE-20257.2.patch,
> HIVE-20257.3.patch, HIVE-20257.4.patch
>
>
> Various fixes to {{Hive.java}}
> * Use Log4J parameters in logging statements
> * Fix check styles
> * Make code more concise
> * Remove "log and throw" code
> * Replaced calls to deprecated code
> * Removed superfluous calls to {{toString}}
>
> "log and throw" is considered and anti-pattern. Only the highest level catch
> should be providing detailed logging otherwise we print the same stack trace
> to the logs several times and with different context (for example when an
> exception is wrapped, we get two different logging events).
>
> https://community.oracle.com/docs/DOC-983543#logAndThrow
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
