[
https://issues.apache.org/jira/browse/HIVE-26243?focusedWorklogId=820026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-820026
]
ASF GitHub Bot logged work on HIVE-26243:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/22 13:11
Start Date: 25/Oct/22 13:11
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3317:
URL: https://github.com/apache/hive/pull/3317#discussion_r1004468411
##########
vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java:
##########
@@ -1955,6 +1962,27 @@ private void generateVectorUDAFComputeBitVector(String[]
tdesc) throws Exception
className, templateString);
}
+ private void generateVectorUDAFComputeKLL(String[] tdesc) throws Exception {
Review Comment:
how is this different from `generateVectorUDAFComputeBitVector` method?
could we reuse it?
Issue Time Tracking
-------------------
Worklog Id: (was: 820026)
Time Spent: 1h 40m (was: 1.5h)
> Add vectorized implementation of the 'ds_kll_sketch' UDAF
> ---------------------------------------------------------
>
> Key: HIVE-26243
> URL: https://issues.apache.org/jira/browse/HIVE-26243
> Project: Hive
> Issue Type: Improvement
> Components: UDF, Vectorization
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> _ds_kll_sketch_ UDAF does not have a vectorized implementation at the moment,
> the present ticket aims at bridging this gap.
> This is particularly important because vectorization has an "all or nothing"
> approach, so if this function is used at the side of vectorized functions,
> they won't be able to benefit from vectorized execution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
