[
https://issues.apache.org/jira/browse/HIVE-26670?focusedWorklogId=821293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-821293
]
ASF GitHub Bot logged work on HIVE-26670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/22 06:27
Start Date: 28/Oct/22 06:27
Worklog Time Spent: 10m
Work Description: cnauroth commented on code in PR #3710:
URL: https://github.com/apache/hive/pull/3710#discussion_r1007678514
##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -182,6 +184,7 @@ public class HiveConnection implements java.sql.Connection {
private Subject loggedInSubject;
private int maxRetries = 1;
private IJdbcBrowserClient browserClient;
+ private Map<String, String> additionalHttpHeaders = new HashMap<String,
String>();
Review Comment:
Was it necessary to promote this to a class member? It appears that usage is
still limited to one method: `getHttpClient`.
##########
jdbc/src/java/org/apache/hive/jdbc/HttpResponseInterceptorBase.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hive.jdbc;
+
+import java.io.IOException;
+
+import org.apache.hadoop.hive.conf.Constants;
+import org.apache.http.HttpException;
+import org.apache.http.HttpResponse;
+import org.apache.http.HttpResponseInterceptor;
+import org.apache.http.protocol.HttpContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class HttpResponseInterceptorBase implements HttpResponseInterceptor {
Review Comment:
Is "Base" the correct naming for this class? In contrast,
`HttpRequestInterceptorBase` is an abstract class that a few different classes
extend.
##########
jdbc/src/java/org/apache/hive/jdbc/HttpRequestInterceptorBase.java:
##########
@@ -19,21 +19,33 @@
package org.apache.hive.jdbc;
import java.io.IOException;
+import java.util.HashMap;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+import org.apache.hadoop.hive.conf.Constants;
import org.apache.http.Header;
import org.apache.http.HttpException;
import org.apache.http.HttpRequest;
import org.apache.http.HttpRequestInterceptor;
import org.apache.http.client.CookieStore;
import org.apache.http.protocol.HttpContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public abstract class HttpRequestInterceptorBase implements
HttpRequestInterceptor {
+ public static final Logger LOG =
LoggerFactory.getLogger(HiveConnection.class.getName());
Review Comment:
Can this be made `private`? Also, is it intentional that this class is
reusing the `HiveConnection` logger? (Are you looking at
`HttpRequestInterceptorBase` as a natural extension of `HiveConnection` from a
logging perspective?)
##########
jdbc/src/java/org/apache/hive/jdbc/HttpResponseInterceptorBase.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hive.jdbc;
+
+import java.io.IOException;
+
+import org.apache.hadoop.hive.conf.Constants;
+import org.apache.http.HttpException;
+import org.apache.http.HttpResponse;
+import org.apache.http.HttpResponseInterceptor;
+import org.apache.http.protocol.HttpContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class HttpResponseInterceptorBase implements HttpResponseInterceptor {
+ public static final Logger LOG =
LoggerFactory.getLogger(HiveConnection.class.getName());
Review Comment:
Similar comment here: can this be `final`, and is it intentional to reuse
the `HiveConnection` logger?
Issue Time Tracking
-------------------
Worklog Id: (was: 821293)
Time Spent: 0.5h (was: 20m)
> Track every single HTTP request between beeline and hs2
> -------------------------------------------------------
>
> Key: HIVE-26670
> URL: https://issues.apache.org/jira/browse/HIVE-26670
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In my use-case there is a couple of layers between beeline and hs2 (load
> balancer, proxies), and I'm about to add something to the requests
> (optionally), that can be simply written to access logs in as many layers as
> possible.
> So instead of:
> {code}
> 2022-10-18T04:34:25+00:00 - [10.80.143.240, 10.80.143.240] - [hs2 host] - [-]
> "POST /cliservice HTTP/1.1" 200 1069 "-" "Java/THttpClient/HC" 703 0.008...
> {code}
> I want to see something specific to the request, which is generated on client
> side, so client can also log it.
> As the title suggests, I'm targeting http transport.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
