[jira] [Work logged] (HIVE-26065) incorrect metric for active calls —— alter_partitions and alter_partition

Fri, 28 Oct 2022 05:42:08 -0700 


     [ 
https://issues.apache.org/jira/browse/HIVE-26065?focusedWorklogId=821419&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-821419
 ]

ASF GitHub Bot logged work on HIVE-26065:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Oct/22 12:41
            Start Date: 28/Oct/22 12:41
    Worklog Time Spent: 10m 
      Work Description: sonarcloud[bot] commented on PR #3133:
URL: https://github.com/apache/hive/pull/3133#issuecomment-1294952935

   Kudos, SonarCloud Quality Gate passed!    [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3133)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3133&resolved=false&types=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3133&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3133&resolved=false&types=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3133&resolved=false&types=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3133&metric=coverage&view=list)
 No Coverage information  
   [![No Duplication 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png
 'No Duplication 
information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3133&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 821419)
    Time Spent: 1h 20m  (was: 1h 10m)

> incorrect metric for active calls ——  alter_partitions and  alter_partition
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-26065
>                 URL: https://issues.apache.org/jira/browse/HIVE-26065
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: DongWei
>            Assignee: DongWei
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-26065.1.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> In our production environment, we found that the value of the metric 
> "active_calls_alter_partition" was negative. This is very confusing.
> After checking the HMSHandler.class, we found that the method 
> alter_partitions_with_environment_context called()
> *startTableFunction("alter_partitions", catName, db_name, tbl_name);* 
> *...* 
> *endFunction("alter_partition", oldParts != null, ex, tbl_name);*
> So the metric "active_calls_alter_partition" will be decremented by one after 
> the "alter_partitions" function execution ends, causing the value become a 
> negative number



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to