[
https://issues.apache.org/jira/browse/HIVE-26670?focusedWorklogId=822259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822259
]
ASF GitHub Bot logged work on HIVE-26670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/22 10:35
Start Date: 01/Nov/22 10:35
Worklog Time Spent: 10m
Work Description: abstractdog commented on code in PR #3710:
URL: https://github.com/apache/hive/pull/3710#discussion_r1010295774
##########
jdbc/src/java/org/apache/hive/jdbc/HttpRequestInterceptorBase.java:
##########
@@ -77,6 +88,14 @@ public void process(HttpRequest httpRequest, HttpContext
httpContext)
if (isCookieEnabled) {
httpContext.setAttribute(Utils.HIVE_SERVER2_RETRY_KEY,
Utils.HIVE_SERVER2_CONST_FALSE);
}
+
+ if (requestTrackingEnabled) {
+ String trackHeader = getNewTrackHeader();
+ LOG.info("{}:{}", Constants.HTTP_HEADER_REQUEST_TRACK, trackHeader);
+ additionalHeaders.put(Constants.HTTP_HEADER_REQUEST_TRACK,
trackHeader);
+ httpContext.setAttribute(Constants.HTTP_HEADER_REQUEST_TRACK,
trackHeader);
+ httpContext.setAttribute(trackHeader +
Constants.TIME_POSTFIX_REQUEST_TRACK, System.currentTimeMillis());
Review Comment:
yeah, I tend to use System.currentTimeMillis(), hadoop util looks better
clearly according to javadoc
Issue Time Tracking
-------------------
Worklog Id: (was: 822259)
Time Spent: 4h 10m (was: 4h)
> Track every single HTTP request between beeline and hs2
> -------------------------------------------------------
>
> Key: HIVE-26670
> URL: https://issues.apache.org/jira/browse/HIVE-26670
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> In my use-case there is a couple of layers between beeline and hs2 (load
> balancer, proxies), and I'm about to add something to the requests
> (optionally), that can be simply written to access logs in as many layers as
> possible.
> So instead of:
> {code}
> 2022-10-18T04:34:25+00:00 - [10.80.143.240, 10.80.143.240] - [hs2 host] - [-]
> "POST /cliservice HTTP/1.1" 200 1069 "-" "Java/THttpClient/HC" 703 0.008...
> {code}
> I want to see something specific to the request, which is generated on client
> side, so client can also log it.
> As the title suggests, I'm targeting http transport.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
