[
https://issues.apache.org/jira/browse/HIVE-26243?focusedWorklogId=823851&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823851
]
ASF GitHub Bot logged work on HIVE-26243:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/22 10:05
Start Date: 07/Nov/22 10:05
Worklog Time Spent: 10m
Work Description: asolimando commented on code in PR #3317:
URL: https://github.com/apache/hive/pull/3317#discussion_r1015227604
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/histogram/KllHistogramEstimator.java:
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.common.histogram;
+
+import org.apache.datasketches.kll.KllFloatsSketch;
+import org.apache.hadoop.hive.common.histogram.kll.KllUtils;
+import org.apache.hadoop.hive.common.type.HiveDecimal;
+import org.apache.hadoop.hive.ql.util.JavaDataModel;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+
+public class KllHistogramEstimator {
Review Comment:
Quoting from
https://github.com/apache/hive/pull/3317#issuecomment-1148553006:
> I am trying to figure out a better place to put an interface plus the
concrete implementation(s) of the "complex" object incapsulating the different
sketches: the only examples I could find are HyperLogLog (stored in the
metastore-server module) and BloomFilter/BloomKFilter (stored in the
storage-api module). As of now I have followed the HyperLogLog example but you
seem to disagree, storage-api seems pretty arbitrary too, so I am not sure how
to proceed here, do you have any suggestions?
Do you have any suggestions for a better place to store those classes?
Issue Time Tracking
-------------------
Worklog Id: (was: 823851)
Time Spent: 3h 40m (was: 3.5h)
> Add vectorized implementation of the 'ds_kll_sketch' UDAF
> ---------------------------------------------------------
>
> Key: HIVE-26243
> URL: https://issues.apache.org/jira/browse/HIVE-26243
> Project: Hive
> Issue Type: Improvement
> Components: UDF, Vectorization
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> _ds_kll_sketch_ UDAF does not have a vectorized implementation at the moment,
> the present ticket aims at bridging this gap.
> This is particularly important because vectorization has an "all or nothing"
> approach, so if this function is used at the side of vectorized functions,
> they won't be able to benefit from vectorized execution.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
