[ 
https://issues.apache.org/jira/browse/HIVE-26631?focusedWorklogId=825731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825731
 ]

ASF GitHub Bot logged work on HIVE-26631:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Nov/22 12:28
            Start Date: 14/Nov/22 12:28
    Worklog Time Spent: 10m 
      Work Description: xiuzhu9527 commented on PR #3672:
URL: https://github.com/apache/hive/pull/3672#issuecomment-1313617911

   @zabetak  I don't think the variables unused are intentional. In thrift 
issuse(https://issues.apache.org/jira/browse/THRIFT-5297 ),the parameters 
requestTimeout and beBackoffSlotLength are removed, because it adds a lot of 
complexity to the code and doesn't make a whole lot of sense. 




Issue Time Tracking
-------------------

    Worklog Id:     (was: 825731)
    Time Spent: 50m  (was: 40m)

> Remove unused variable requestTimeout and beBackoffSlotLength in the 
> initServer method of the ThriftBinaryCLIService class
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-26631
>                 URL: https://issues.apache.org/jira/browse/HIVE-26631
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0-alpha-1
>            Reporter: weiliang hao
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Upgrade thrift from 0.13.0 to 0.14.1 in 
> issuse(https://issues.apache.org/jira/browse/HIVE-25098), The settings of 
> requestTimeout and beBackoffSlotLength are removed for TThreadPoolServer.Args 
> objects. However, variable requestTimeout and beBackoffSlotLength unused, 
> better to clean up them and HiveConf:
>  * hive.server2.thrift.exponential.backoff.slot.length
>  * hive.server2.thrift.login.timeout



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to