[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=827093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827093
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/22 09:04
Start Date: 18/Nov/22 09:04
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1026179515
##########
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##########
@@ -493,7 +494,7 @@ public static boolean isCompactionTable(Properties
tblProperties) {
* @return true, if the parameters contains {@link
AcidUtils#COMPACTOR_TABLE_PROPERTY}
*/
public static boolean isCompactionTable(Map<String, String> parameters) {
- return Boolean.parseBoolean(parameters.get(COMPACTOR_TABLE_PROPERTY));
+ return StringUtils.isNotBlank(parameters.get(COMPACTOR_TABLE_PROPERTY));
Review Comment:
It is set only by the
[CompactionQueryBuilder](https://github.com/apache/hive/blob/e3751ab545370f9b252d0b4a07bc315037541a95/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java),
and from now on it is setting the compaction type instead of `true/false`.
Issue Time Tracking
-------------------
Worklog Id: (was: 827093)
Time Spent: 3.5h (was: 3h 20m)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
