[
https://issues.apache.org/jira/browse/HIVE-24120?focusedWorklogId=828078&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828078
]
ASF GitHub Bot logged work on HIVE-24120:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/22 15:52
Start Date: 22/Nov/22 15:52
Worklog Time Spent: 10m
Work Description: tthorpeIBM opened a new pull request, #3799:
URL: https://github.com/apache/hive/pull/3799
### What changes were proposed in this pull request?
This PR assumes that if ConfVars.USE_CUSTOM_RDBMS is set that we will expect
DbType.CUSTOM, therefore, it will not use DbType.UNDEFINED to compare to the
database type set in theDatabaseProduct.
### Why are the changes needed?
getDbType(productName) returns DbType.UNDEFINED
But when theDatabaseProduct == null and ConfVars.USE_CUSTOM_RDBMS is set
theDatabaseProduct.dbType is initialized to DbType.CUSTOM. DbType.UNDEFINED
will never equal DbType.CUSTOM
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I compile the code, added a subclass of DatabaseProduct for Db2 and
installed Hive Metastore using a backend Db2 database.
Issue Time Tracking
-------------------
Worklog Id: (was: 828078)
Time Spent: 3h 10m (was: 3h)
> Plugin for external DatabaseProduct in standalone HMS
> -----------------------------------------------------
>
> Key: HIVE-24120
> URL: https://issues.apache.org/jira/browse/HIVE-24120
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Affects Versions: 3.1.1
> Reporter: Gustavo Arocena
> Assignee: Gustavo Arocena
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-1
>
> Attachments: External database support.pdf
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Add a pluggable way to support ANSI compliant databases as backends for
> standalone HMS
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
