[ 
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=828889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828889
 ]

ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Nov/22 10:54
            Start Date: 25/Nov/22 10:54
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1032279021


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Compactor.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.txn.compactor;
+
+import org.apache.hadoop.hive.common.ValidWriteIdList;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.StorageDescriptor;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.hadoop.hive.metastore.txn.CompactionInfo;
+import org.apache.hadoop.hive.ql.io.AcidDirectory;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+import java.io.IOException;
+
+public abstract class Compactor {
+
+  /**
+   * Start a compaction.
+   * @param hiveConf hive configuration
+   * @param table the table, where the compaction should run
+   * @param partition the partition, where the compaction should run
+   * @param storageDescriptor this is the resolved storage descriptor
+   * @param writeIds valid write IDs used to filter rows while they're being 
read for compaction
+   * @param compactionInfo provides info about the type of compaction
+   * @param dir provides ACID directory layout information
+   * @throws IOException compaction cannot be finished.
+   */
+  abstract void runCompaction(HiveConf hiveConf, Table table, Partition 
partition, StorageDescriptor storageDescriptor,

Review Comment:
   simply run()?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 828889)
    Time Spent: 7h 20m  (was: 7h 10m)

> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
>                 Key: HIVE-26716
>                 URL: https://issues.apache.org/jira/browse/HIVE-26716
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: László Végh
>            Assignee: László Végh
>            Priority: Major
>              Labels: ACID, compaction, pull-request-available
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to