[
https://issues.apache.org/jira/browse/HIVE-26770?focusedWorklogId=829558&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829558
]
ASF GitHub Bot logged work on HIVE-26770:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/22 07:28
Start Date: 29/Nov/22 07:28
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3803:
URL: https://github.com/apache/hive/pull/3803#discussion_r1034383419
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorThread.java:
##########
@@ -219,4 +226,17 @@ protected LockRequest createLockRequest(CompactionInfo ci,
long txnId, LockType
!conf.getBoolVar(HiveConf.ConfVars.TXN_WRITE_X_LOCK));
return requestBuilder.build();
}
+
+ protected void doPostLoopActions(long elapsedTime, CompactorThreadType type)
throws InterruptedException {
+ if (elapsedTime < checkInterval && !stop.get()) {
+ Thread.sleep(checkInterval - elapsedTime);
+ }
+
+ if(elapsedTime < MAX_WARN_LOG_TIME){
Review Comment:
nit: space
Issue Time Tracking
-------------------
Worklog Id: (was: 829558)
Time Spent: 1h 50m (was: 1h 40m)
> Make "end of loop" compaction logs appear more selectively
> ----------------------------------------------------------
>
> Key: HIVE-26770
> URL: https://issues.apache.org/jira/browse/HIVE-26770
> Project: Hive
> Issue Type: Improvement
> Reporter: Akshat Mathur
> Assignee: Akshat Mathur
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently Initiator, Worker, and Cleaner threads log something like "finished
> one loop" on INFO level.
> This is useful to figure out if one of these threads is taking too long to
> finish a loop, but expensive in general.
>
> Suggested Time: 20mins
> Logging this should be changed in the following way
> # If loop finished within a predefined amount of time, level should be DEBUG
> and message should look like: *Initiator loop took \{ellapsedTime} seconds to
> finish.*
> # If loop ran longer than this predefined amount, level should be WARN and
> message should look like: *Possible Initiator slowdown, loop took
> \{ellapsedTime} seconds to finish.*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
