[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=829584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829584
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/22 08:28
Start Date: 29/Nov/22 08:28
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1034435640
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java:
##########
@@ -200,22 +207,22 @@ CompactionQueryBuilder setIsDeleteDelta(boolean
deleteDelta) {
* @param compactionType major or minor; crud or insert-only, e.g.
CompactionType.MAJOR_CRUD.
* Cannot be null.
* @param operation query's Operation e.g. Operation.CREATE.
- * @param resultTableName the name of the table we are running the operation
on
+ * @param insertOnly Inidicated if the table is not full ACID but
Insert-only (Micromanaged)
* @throws IllegalArgumentException if compactionType is null
*/
- CompactionQueryBuilder(CompactionType compactionType, Operation operation,
+ CompactionQueryBuilder(CompactionType compactionType, Operation operation,
boolean insertOnly,
String resultTableName) {
if (compactionType == null) {
throw new
IllegalArgumentException("CompactionQueryBuilder.CompactionType cannot be
null");
}
+ this.compactionType = compactionType;
this.operation = operation;
this.resultTableName = resultTableName;
- major = compactionType == CompactionType.MAJOR_CRUD
- || compactionType == CompactionType.MAJOR_INSERT_ONLY;
- crud =
- compactionType == CompactionType.MAJOR_CRUD || compactionType ==
CompactionType.MINOR_CRUD;
- minor = !major;
- insertOnly = !crud;
+ this.insertOnly = insertOnly;
+
+ if(CompactionType.REBALANCE.equals(compactionType) && insertOnly) {
Review Comment:
nit: space
Issue Time Tracking
-------------------
Worklog Id: (was: 829584)
Time Spent: 15.5h (was: 15h 20m)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 15.5h
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
