[
https://issues.apache.org/jira/browse/HIVE-26771?focusedWorklogId=829966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829966
]
ASF GitHub Bot logged work on HIVE-26771:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/22 07:50
Start Date: 30/Nov/22 07:50
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3802:
URL: https://github.com/apache/hive/pull/3802#discussion_r1035630068
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java:
##########
@@ -120,16 +114,11 @@ public void initialize(@Nullable Configuration
configuration, Properties serDePr
this.tableSchema = hiveSchemaOrThrow(e, autoConversion);
// This is only for table creation, it is ok to have an empty
partition column list
this.partitionColumns = ImmutableList.of();
- // create table for CTAS
- if (e instanceof NoSuchTableException &&
-
Boolean.parseBoolean(serDeProperties.getProperty(hive_metastoreConstants.TABLE_IS_CTAS)))
{
- if (!Catalogs.hiveCatalog(configuration, serDeProperties)) {
- throw new SerDeException(CTAS_EXCEPTION_MSG);
- }
- if (!serDeProperties.containsKey(Constants.EXPLAIN_CTAS_LOCATION)) {
- createTableForCTAS(configuration, serDeProperties);
- }
+ if (e instanceof NoSuchTableException &&
+
Boolean.parseBoolean(serDeProperties.getProperty(hive_metastoreConstants.TABLE_IS_CTAS))
&&
Review Comment:
use the helper method, suggested above
Issue Time Tracking
-------------------
Worklog Id: (was: 829966)
Time Spent: 1h 20m (was: 1h 10m)
> Use DDLTask to created Iceberg table when running ctas statement
> ----------------------------------------------------------------
>
> Key: HIVE-26771
> URL: https://issues.apache.org/jira/browse/HIVE-26771
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When Iceberg table is created via ctas statement the table is created in
> HiveIcebergSerDe and no DDL task is executed.
> Negative effects of this workflow:
> * Missing table properties: format-version, write.[delete|update|merge].mode
> * Default privileges of the new table are not granted.
> * The new Iceberg table can be seen by other transactions at compile time of
> ctas.
> * Table creation and table properties are not shown in explain ctas output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
