[
https://issues.apache.org/jira/browse/HIVE-26692?focusedWorklogId=830185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830185
]
ASF GitHub Bot logged work on HIVE-26692:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Nov/22 19:15
Start Date: 30/Nov/22 19:15
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3820:
URL: https://github.com/apache/hive/pull/3820#discussion_r1036354399
##########
pom.xml:
##########
@@ -1773,6 +1773,35 @@
<id>thriftif</id>
<build>
<plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>1.2.1</version>
Review Comment:
Seems the version is different that the one being used in hive
https://github.com/apache/hive/blob/81909f3ed294a5c095797346d26d1d1917d42c3a/standalone-metastore/pom.xml#L43
Good if we can extract the variable and use the same variable at all places
Issue Time Tracking
-------------------
Worklog Id: (was: 830185)
Time Spent: 0.5h (was: 20m)
> Check for the expected thrift version before compiling
> ------------------------------------------------------
>
> Key: HIVE-26692
> URL: https://issues.apache.org/jira/browse/HIVE-26692
> Project: Hive
> Issue Type: Task
> Components: Thrift API
> Affects Versions: 4.0.0-alpha-2
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> At the moment we don't check for the thrift version before launching thrift,
> the error messages are often cryptic upon mismatches.
> An explicit check with a clear error message would be nice, like what parquet
> does:
> [https://github.com/apache/parquet-mr/blob/master/parquet-thrift/pom.xml#L247-L268]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
