[
https://issues.apache.org/jira/browse/HIVE-26843?focusedWorklogId=833206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833206
]
ASF GitHub Bot logged work on HIVE-26843:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/22 21:33
Start Date: 13/Dec/22 21:33
Worklog Time Spent: 10m
Work Description: cnauroth commented on PR #3853:
URL: https://github.com/apache/hive/pull/3853#issuecomment-1349761526
@zabetak , thank you for reviewing #3839 last week. This is a follow-up. I
discovered that there are in fact other dependency module descriptors getting
into the Hive shaded jars. Would you mind reviewing this one too? Thank you.
Issue Time Tracking
-------------------
Worklog Id: (was: 833206)
Time Spent: 20m (was: 10m)
> Filter all dependency module descriptors from shaded jars.
> ----------------------------------------------------------
>
> Key: HIVE-26843
> URL: https://issues.apache.org/jira/browse/HIVE-26843
> Project: Hive
> Issue Type: Improvement
> Components: Beeline, Hive, JDBC
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> HIVE-26813 upgraded HikariCP from 2.6.1 to 4.0.3. During review of
> [PR#3839|https://github.com/apache/hive/pull/3839], we discussed the need to
> omit its module descriptor (module-info.class) from shaded jars. However, it
> turns out there are also existing instances of module-info.class files from
> other dependencies like Jackson and Log4J leaking into the shaded jars. We
> can update the shading filters with wildcards to exclude these and also make
> it future-proof against any other dependencies that start including a module
> descriptor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
