[
https://issues.apache.org/jira/browse/HIVE-26699?focusedWorklogId=833902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-833902
]
ASF GitHub Bot logged work on HIVE-26699:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/22 16:45
Start Date: 15/Dec/22 16:45
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3862:
URL: https://github.com/apache/hive/pull/3862#discussion_r1049891756
##########
iceberg/iceberg-shading/pom.xml:
##########
@@ -112,7 +112,11 @@
<include>com.google*:*</include>
<include>com.fasterxml*:*</include>
<include>com.github.ben-manes*:*</include>
+ <include>org.apache.hive:patched-iceberg-core</include>
Review Comment:
it was always there, I changed the iceberg-core to patched iceberg-core, the
flow is like the patched modules -> then the iceberg-shading jar which contains
all changes + some thirdparty libs -> then all this goes to
hive-iceberg-handler with our hive copied modules
And this is the only one complete jar which is packaged.
Issue Time Tracking
-------------------
Worklog Id: (was: 833902)
Time Spent: 50m (was: 40m)
> Iceberg: S3 fadvise can hurt JSON parsing significantly in DWX
> --------------------------------------------------------------
>
> Key: HIVE-26699
> URL: https://issues.apache.org/jira/browse/HIVE-26699
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Hive reads JSON metadata information (TableMetadataParser::read()) multiple
> times; E.g during query compilation, AM split computation, stats computation,
> during commits etc.
>
> With large JSON files (due to multiple inserts), it takes a lot longer time
> with S3 FS with "fs.s3a.experimental.input.fadvise" set to "random". (e.g in
> the order of 10x).To be on safer side, it will be good to set this to
> "normal" mode in configs, when reading iceberg tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
