[
https://issues.apache.org/jira/browse/HIVE-26875?focusedWorklogId=835004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-835004
]
ASF GitHub Bot logged work on HIVE-26875:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/22 09:00
Start Date: 21/Dec/22 09:00
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3887:
URL: https://github.com/apache/hive/pull/3887#discussion_r1054134017
##########
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:
##########
@@ -261,6 +274,8 @@ private boolean validateTxnList() throws
CommandProcessorException {
String userFromUGI = DriverUtils.getUserFromUGI(driverContext);
driverContext.getTxnManager().openTxn(context, userFromUGI,
driverContext.getTxnType());
+ // this is used by the test framework to more easily generate
conflicting transactions
+ if (testConflictCB != null) testConflictCB.run();
Review Comment:
Strong NO for this approach. Use mocking techniques and refactor the code if
needed. There shouldn't be any test hacks in the production code.
Issue Time Tracking
-------------------
Worklog Id: (was: 835004)
Time Spent: 40m (was: 0.5h)
> Transaction conflict retry loop only executes once
> --------------------------------------------------
>
> Key: HIVE-26875
> URL: https://issues.apache.org/jira/browse/HIVE-26875
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the "conflict retry loop" only executes once.
> [https://github.com/apache/hive/blob/ab4c53de82d4aaa33706510441167f2df55df15e/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L264]
> The intent of this loop is to detect if a conflicting transaction has
> committed while we were waiting to acquire locks. If there is a conflicting
> transaction, it invalidates the snapshot, rolls-back the transaction, opens a
> new transaction and tries to re-acquire locks (and then recompile). It then
> checks again if a conflicting transaction has committed and if so, redoes the
> above steps again, up to HIVE_TXN_MAX_RETRYSNAPSHOT_COUNT times.
> However - isValidTxnState relies on getNonSharedLockedTable():
> [https://github.com/apache/hive/blob/ab4c53de82d4aaa33706510441167f2df55df15e/ql/src/java/org/apache/hadoop/hive/ql/DriverTxnHandler.java#L422]
> which does:
> {code:java}
> private Set<String> getNonSharedLockedTables() {
> if (CollectionUtils.isEmpty(driver.getContext().getHiveLocks())) {
> return Collections.emptySet(); // Nothing to check
> }{code}
> getHiveLocks gets populated by lockAndRespond... HOWEVER -
> compileInternal ends up calling compile which ends up calling
> preparForCompile which ends up calling prepareContext which ends up
> destroying the context with the information lockAndRespond populated. So when
> the loop executes after all of this, it will never detect a 2nd conflict
> because isValidTxnState will always return true (because it thinks there are
> no locked objects).
> This manifests as duplicate records being created during concurrent UPDATEs
> if a transaction get conflicted twice.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
