[
https://issues.apache.org/jira/browse/HIVE-26794?focusedWorklogId=835333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-835333
]
ASF GitHub Bot logged work on HIVE-26794:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/22 14:54
Start Date: 22/Dec/22 14:54
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3817:
URL: https://github.com/apache/hive/pull/3817#discussion_r1055545569
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -6188,6 +6188,12 @@ public Connection getConnection(String username, String
password) throws SQLExce
connectionProps.setProperty("user", username);
connectionProps.setProperty("password", password);
Connection conn = driver.connect(connString, connectionProps);
+ String prepareStmt = dbProduct != null ? dbProduct.getPrepareTxnStmt()
: null;
Review Comment:
why is this required, I can see the same in DbCPDataSourceProvider:
````
String stmt = dbProduct.getPrepareTxnStmt();
if (stmt != null) {
poolableConnFactory.setValidationQuery(stmt);
}
````
Issue Time Tracking
-------------------
Worklog Id: (was: 835333)
Time Spent: 2h 50m (was: 2h 40m)
> Explore retiring TxnHandler#connPoolMutex idle connections
> ----------------------------------------------------------
>
> Key: HIVE-26794
> URL: https://issues.apache.org/jira/browse/HIVE-26794
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Instead of creating a fixed size connection pool for TxnHandler#MutexAPI, the
> pool can be assigned to a more dynamic size pool due to:
> * TxnHandler#MutexAPI is primarily designed to provide coarse-grained mutex
> support to maintenance tasks running inside the Metastore, these tasks are
> not user faced;
> * A fixed size connection pool as same as the pool used in ObjectStore is a
> waste for other non leaders in the warehouse;
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
