[
https://issues.apache.org/jira/browse/HIVE-26702?focusedWorklogId=835400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-835400
]
ASF GitHub Bot logged work on HIVE-26702:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Dec/22 19:52
Start Date: 22/Dec/22 19:52
Worklog Time Spent: 10m
Work Description: cnauroth commented on PR #3815:
URL: https://github.com/apache/hive/pull/3815#issuecomment-1363285388
> Thanx @cnauroth Sorry for coming back late, was stuck with couple of
things. Almost looks good. Regarding:
>
> > This patch introduced support for DBCP as a connection pool for the
metastore database. It also corrected HIkariCP configuration by changing a
pooling type constant from "hikari" to "hikaricp".
>
> Why there is no HiveConf Changes?
>
> ```
> - "hikari.,"+
> + "hikaricp.," +
> + "dbcp.,
> ```
@ayushtkn , no worries on delays, and thanks for catching that!
For some reason, the `HiveConf` change was not included in the
[HIVE-17317](https://issues.apache.org/jira/browse/HIVE-17317) commit
(16e6b837d96050b0837086c8dd171c71d9c0bcee) even though it was present in the
patch file attachment. It looks like that was later corrected in
[HIVE-19486](https://issues.apache.org/jira/browse/HIVE-19486). I started my
backport from the git commit, not the file attachment, so I missed this part.
I have pushed up a change to correct this.
Issue Time Tracking
-------------------
Worklog Id: (was: 835400)
Time Spent: 1h 20m (was: 1h 10m)
> Backport HIVE-17317 (DBCP and HikariCP property configuration support) to
> 3.2.0.
> --------------------------------------------------------------------------------
>
> Key: HIVE-26702
> URL: https://issues.apache.org/jira/browse/HIVE-26702
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.2.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> HIVE-17317 added support for metastore connection pooling configuration,
> integration with DBCP and an important capability to the HikariCP
> integration: passthrough configuration of any additional HikariCP
> configurations, such as {{{}minimumIdle{}}}. This issue proposes to backport
> HIVE-17317 for inclusion in the upcoming 3.2.0 release.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
