[ 
https://issues.apache.org/jira/browse/HIVE-26840?focusedWorklogId=836061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836061
 ]

ASF GitHub Bot logged work on HIVE-26840:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Dec/22 05:52
            Start Date: 29/Dec/22 05:52
    Worklog Time Spent: 10m 
      Work Description: amanraj2520 commented on PR #3859:
URL: https://github.com/apache/hive/pull/3859#issuecomment-1367087549

   Hi @cnauroth Thanks a lot for your analysis. This helps me a lot. I will 
check this from my side in sometime and let you know. The thing that you were 
curious about, i think I can help sharing some light. Arrow started using netty 
in its 0.x releases. If we do not exclude netty from arrow while importing 
dependencies it will get the 4.1.22.Final netty. A point to be noted is that 
4.1.22.Final and 4.1.28.Final(which I was planning to revert to) does not have 
this nonNull check in its stack trace. Therefore even if we upgrade netty to 
4.1.69.Final and keep arrow as 0.x, it will pickup the 4.1.22.Final which will 
not have the nonNull check and it will pass. The problem came because we 
removed the arrow's netty in branch-3 while importing therefore forcing arrow 
to use 4.1.69.Final which has this null check and therefore this test fails. 
Hope this answers you question. We can discuss it further if you want. 
   
   Having said this i also feel that fixing this test is the best approach and 
I will try fixing that in another pr. Will wait for someone to approve this 
first. Thanks a lot @cnauroth 




Issue Time Tracking
-------------------

    Worklog Id:     (was: 836061)
    Time Spent: 4h  (was: 3h 50m)

> Backport of HIVE-23073 and HIVE-24138
> -------------------------------------
>
>                 Key: HIVE-26840
>                 URL: https://issues.apache.org/jira/browse/HIVE-26840
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Aman Raj
>            Assignee: Aman Raj
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 4h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to