[
https://issues.apache.org/jira/browse/HIVE-26880?focusedWorklogId=836718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836718
]
ASF GitHub Bot logged work on HIVE-26880:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/23 19:43
Start Date: 03/Jan/23 19:43
Worklog Time Spent: 10m
Work Description: cnauroth commented on code in PR #3886:
URL: https://github.com/apache/hive/pull/3886#discussion_r1060901243
##########
service/pom.xml:
##########
@@ -291,13 +291,6 @@
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.directory.client.ldap</groupId>
- <artifactId>ldap-client-api</artifactId>
- <version>${apache-directory-clientapi.version}</version>
- <scope>test</scope>
- </dependency>
-
<dependency>
<groupId>org.apache.directory.server</groupId>
<artifactId>apacheds-server-integ</artifactId>
Review Comment:
Commit 5581eb8a74a4f33b35b7bf70d9ec4e9a95f3b8a0 actually removed the
exclusion from the existing codebase. This exclusion is not present in
branch-3, so there isn't anything for this patch to remove.
If I run `mvn dependency:tree` on master, I see the same transitive
dependency. Looking back on the history of
[HIVE-21836](https://issues.apache.org/jira/browse/HIVE-21836), I see there was
a Jenkins run for HIVE-21836.01.patch, which did not remove the exclusion, and
it had a test failure in `TestLdapAtnProviderWithMiniDS`. Then,
HIVE-21836.02.patch removed the exclusion, and it got a successful Jenkins run.
I can't reproduce that problem though. I tried adding the exclusion back, and
the test still passed fine for me.
Let me know if you think we should bring back this exclusion on both master
and branch-3. Thanks!
Issue Time Tracking
-------------------
Worklog Id: (was: 836718)
Time Spent: 1h (was: 50m)
> Upgrade Apache Directory Server to 1.5.7 for release 3.2.
> ---------------------------------------------------------
>
> Key: HIVE-26880
> URL: https://issues.apache.org/jira/browse/HIVE-26880
> Project: Hive
> Issue Type: Improvement
> Components: Test
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Labels: hive-3.2.0-must, pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> branch-3 uses Apache Directory Server in some tests. It currently uses
> version 1.5.6. This version has a transitive dependency to a SNAPSHOT, making
> it awkward to build and release. We can upgrade to 1.5.7 to remove the
> SNAPSHOT dependency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
