[ 
https://issues.apache.org/jira/browse/HIVE-26908?focusedWorklogId=837406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837406
 ]

ASF GitHub Bot logged work on HIVE-26908:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jan/23 05:09
            Start Date: 06/Jan/23 05:09
    Worklog Time Spent: 10m 
      Work Description: akshat0395 commented on code in PR #3915:
URL: https://github.com/apache/hive/pull/3915#discussion_r1063109875


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/leader/CompactorTasks.java:
##########
@@ -110,6 +113,9 @@ private void logCompactionParameters() {
       if (!MetastoreConf.getBoolVar(configuration, 
MetastoreConf.ConfVars.COMPACTOR_INITIATOR_ON)) {
         HiveMetaStore.LOG.warn("Compactor Initiator is turned Off. Automatic 
compaction will not be triggered.");
       }
+      HiveMetaStore.LOG.info(

Review Comment:
   As we are already printing the of COMPACTOR_CLEANER_ON as INFO log on line 
96, do we really need this log?
   Can this be similar to the WARN log for initiator from line 113 and give a 
warn log if cleaner is turned off and automatic cleaner will be be triggered? 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 837406)
    Time Spent: 0.5h  (was: 20m)

> Disable Initiator on HMS instance at the same time enable Cleaner thread
> ------------------------------------------------------------------------
>
>                 Key: HIVE-26908
>                 URL: https://issues.apache.org/jira/browse/HIVE-26908
>             Project: Hive
>          Issue Type: New Feature
>          Components: Standalone Metastore
>            Reporter: Taraka Rama Rao Lethavadla
>            Assignee: Taraka Rama Rao Lethavadla
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In the current implementation, both Initiator and Cleaner are either enabled 
> or disabled using the same configĀ 
> {noformat}
> hive.compactor.initiator.on{noformat}
> So there is no way to selectively disable initiator and enable cleaner or 
> vice versa.
> Introducing another config to handle Cleaner thread alone like 
> hive.compactor.cleaner.on



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to