[
https://issues.apache.org/jira/browse/HIVE-26794?focusedWorklogId=837824&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837824
]
ASF GitHub Bot logged work on HIVE-26794:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/23 08:42
Start Date: 09/Jan/23 08:42
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #3817:
URL: https://github.com/apache/hive/pull/3817#discussion_r1064388078
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java:
##########
@@ -143,6 +148,62 @@ public void testCreateDbCpDataSource() throws SQLException
{
Assert.assertTrue(ds instanceof PoolingDataSource);
}
+ @Test
+ public void testEvictIdleConnection() throws Exception {
+ String[] dataSourceType = {HikariCPDataSourceProvider.HIKARI,
DbCPDataSourceProvider.DBCP};
+ try (DataSourceProvider.DataSourceNameConfigurator configurator =
+ new DataSourceProvider.DataSourceNameConfigurator(conf, "mutex"))
{
+ for (final String type: dataSourceType) {
+ MetastoreConf.setVar(conf, ConfVars.CONNECTION_POOLING_TYPE, type);
+ boolean isHikari = HikariCPDataSourceProvider.HIKARI.equals(type);
+ if (isHikari) {
+ conf.unset("hikaricp.connectionInitSql");
+ // The minimum of idleTimeout is 10s
+ conf.set("hikaricp.idleTimeout", "10000");
+ System.setProperty("com.zaxxer.hikari.housekeeping.periodMs",
"1000");
+ } else {
+ conf.set("dbcp.timeBetweenEvictionRunsMillis", "1000");
+ conf.set("dbcp.softMinEvictableIdleTimeMillis", "3000");
+ conf.set("dbcp.maxIdle", "0");
+ }
+ DataSourceProvider dsp =
DataSourceProviderFactory.tryGetDataSourceProviderOrNull(conf);
+ DataSource ds = dsp.create(conf, 5);
+ List<Connection> connections = new ArrayList<>();
+ for (int i = 0; i < 5; i++) {
+ connections.add(ds.getConnection());
+ }
+ HikariPoolMXBean poolMXBean = null;
+ GenericObjectPool objectPool = null;
+ if (isHikari) {
+ poolMXBean = ((HikariDataSource) ds).getHikariPoolMXBean();
+ Assert.assertEquals(5, poolMXBean.getTotalConnections());
+ Assert.assertEquals(5, poolMXBean.getActiveConnections());
+ } else {
+ Method getPool =
PoolingDataSource.class.getDeclaredMethod("getPool");
Review Comment:
Done, thank you for the suggestion!
Issue Time Tracking
-------------------
Worklog Id: (was: 837824)
Time Spent: 4h 20m (was: 4h 10m)
> Explore retiring TxnHandler#connPoolMutex idle connections
> ----------------------------------------------------------
>
> Key: HIVE-26794
> URL: https://issues.apache.org/jira/browse/HIVE-26794
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Instead of creating a fixed size connection pool for TxnHandler#MutexAPI, the
> pool can be assigned to a more dynamic size pool due to:
> * TxnHandler#MutexAPI is primarily designed to provide coarse-grained mutex
> support to maintenance tasks running inside the Metastore, these tasks are
> not user faced;
> * A fixed size connection pool as same as the pool used in ObjectStore is a
> waste for other non leaders in the warehouse;
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
