[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=838181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838181
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/23 05:34
Start Date: 10/Jan/23 05:34
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1065348961
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5150,6 +5169,7 @@ private int abortTxns(Connection dbConn, List<Long>
txnids, boolean checkHeartbe
if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON)) {
Metrics.getOrCreateCounter(MetricsConstants.TOTAL_NUM_ABORTED_TXNS).inc(txnids.size());
}
+ LOG.warn("Aborted {} transactions {} due to {}", txnids.size(), txnids,
errorMsg);
Review Comment:
Done.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnErrorMsg.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.txn;
+
+/**
+ * The following class represents all the error messages that are handled for
aborts.
+ */
+public enum TxnErrorMsg {
+ // Txn Errors Codes: 50000 - 59999.
+ // Query runtime aborts - 50000-50999
+ NONE(50000, "none"),
+ ABORT_QUERY(50001, "abort by Query command"),
Review Comment:
Fixed.
Issue Time Tracking
-------------------
Worklog Id: (was: 838181)
Time Spent: 15h 10m (was: 15h)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
