[
https://issues.apache.org/jira/browse/HIVE-26565?focusedWorklogId=838406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838406
]
ASF GitHub Bot logged work on HIVE-26565:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/23 18:14
Start Date: 10/Jan/23 18:14
Worklog Time Spent: 10m
Work Description: simhadri-g commented on code in PR #2:
URL: https://github.com/apache/hive-site/pull/2#discussion_r1066135163
##########
themes/hive/layouts/partials/footer.html:
##########
@@ -0,0 +1,55 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License. -->
+
+<footer class="black-background static-bottom" style="padding:30px">
+ <div class="row">
+ <div class="col-3">
+ <a href="{{ .Site.Params.apache.apacheURL }}">
+ <img src="{{.Site.BaseURL}}{{ .Site.Params.logo }}"
width="270" height="100" alt="Apache Software Foundation"></a>
+ </a>
+ </div>
+ <div class="col-9">
+ <p class="footer-text">Apache is a non-profit organization helping
open-source
+ software projects released under the Apache
+ <a href="{{ .Site.Params.apache.license }}">license</a>
+ and managed with
+ <a href="{{ .Site.Params.apache.howItWorks }}">
+ open governance</a> and
+ <a href="{{ .Site.Params.apache.privacyPolicy }}">
+ privacy policy</a>. See upcoming
+ <a href="{{ .Site.Params.apache.apacheEvents }}">Apache
Events</a>.
+ If you discover any
+ <a href="{{ .Site.Params.apache.security }}">security</a>
vulnerabilities, please
+ report them privately. Finally,
+ <a href="{{ .Site.Params.apache.sponsors }}">thanks
+ </a> to the sponsors who
+ <a href="{{ .Site.Params.apache.donate }}">
+ donate</a> to the Apache Foundation.
+ </p>
+ </div>
+
+
+ </div>
+ <div class="copyright row">
+ <a href="{{ .Site.BaseURL }}" style="color:grey">
+ {{ with .Site.Params.Apache.Copyright | default .Site.Title }} {{
. | safeHTML }} {{ end }}
+ </a>
+ </div>
+
+</footer>
+<script
src="https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js";
integrity="sha384-MrcW6ZMFYlzcLA8Nl+NtUVF0sA7MsXsP1UyJoMp4YLEuNSfAP+JcXn/tWtIaxVXM"
crossorigin="anonymous"></script>
Review Comment:
Yes, it is safe.
Bootstrap is included via CDN from the official source mentioned here:
https://getbootstrap.com/
It looks like it is encrypted using SHA-384 which belongs to the same family
as SHA-2.
SHA-384 is supposed to be a faster hashing algorithm on 64-bit machines.
##########
themes/hive/layouts/partials/head.html:
##########
@@ -0,0 +1,41 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License. -->
+<!DOCTYPE html>
+<html>
+ <head>
+
+ <meta charset="utf-8">
+ <meta http-equiv="X-UA-Compatible" content="IE=edge">
+ <meta name="viewport" content="width=device-width, initial-scale=1">
+ <meta name="description" content="">
+ <meta name="author" content="">
+ <title>{{ .Title }}</title>
+ <link rel="icon" href="/images/hive.svg" sizes="any"
type="image/svg+xml">
+ <link rel="stylesheet" href="{{ .Site.BaseURL }}/css/hive-theme.css" />
+ <link rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css";>
+ <link
href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css";
rel="stylesheet"
integrity="sha384-EVSTQN3/azprG1Anm3QDgpJLIm9Nao0Yz1ztcQTwFspd3yD65VohhpuuCOmLASjC"
crossorigin="anonymous">
Review Comment:
Yes, it is safe.
Bootstrap is included via CDN from the official source mentioned here:
https://getbootstrap.com/
It looks like it is encrypted using SHA-384 which belongs to the same family
as SHA-2.
SHA-384 is supposed to be a faster hashing algorithm on 64-bit machines.
Issue Time Tracking
-------------------
Worklog Id: (was: 838406)
Time Spent: 5h 10m (was: 5h)
> Revamp Apache Hive website
> --------------------------
>
> Key: HIVE-26565
> URL: https://issues.apache.org/jira/browse/HIVE-26565
> Project: Hive
> Issue Type: Improvement
> Components: Website
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
>
> The existing apache hive website
> [https://hive.apache.org|https://hive.apache.org/]/ hasn't been updated for a
> very long time. Since the website is the front page of the project, I believe
> it would be good to revamp the apache hive website with the latest features
> and releases.
> As discussed in the mail chain below, I am raising this jira to track the
> efforts for the same.
> Mail chain: [https://www.mail-archive.com/[email protected]/msg22568.html]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
