[ 
https://issues.apache.org/jira/browse/HIVE-26889?focusedWorklogId=838512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838512
 ]

ASF GitHub Bot logged work on HIVE-26889:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jan/23 04:06
            Start Date: 11/Jan/23 04:06
    Worklog Time Spent: 10m 
      Work Description: SourabhBadhya commented on code in PR #3896:
URL: https://github.com/apache/hive/pull/3896#discussion_r1066554355


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFArrayBase.java:
##########
@@ -49,6 +52,12 @@ protected AbstractGenericUDFArrayBase(String functionName, 
int minArgCount, int
         this.minArgCount = minArgCount;
         this.maxArgCount = maxArgCount;
         this.outputCategory = outputCategory;
+        this.outputPrimitiveCategory = null;
+    }
+
+    public AbstractGenericUDFArrayBase(String functionName, int minArgCount, 
int maxArgCount, ObjectInspector.Category outputCategory, 
PrimitiveObjectInspector.PrimitiveCategory outputPrimitiveCategory) {

Review Comment:
   Probably this constructor and variable might not be required in this class.
   Please check this comment - 
https://github.com/apache/hive/pull/3896/files#r1066553884.
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 838512)
    Time Spent: 50m  (was: 40m)

> Implement array_join udf to concatenate the elements of an array with a 
> specified delimiter
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-26889
>                 URL: https://issues.apache.org/jira/browse/HIVE-26889
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Taraka Rama Rao Lethavadla
>            Assignee: Taraka Rama Rao Lethavadla
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> *array_join(array, delimiter, replaceNull)* - concatenate the elements of an 
> array with a specified delimiter
> Example:
> {noformat}
> > SELECT array_join(array(1, 2, 3,4), ',') FROM src LIMIT 1;
> 1,2,3,4
> > SELECT array_join(array(1, 2, NULL, 4), ',',':') FROM src LIMIT 1;
> 1,2,:,4{noformat}
> Returns NULL if array is null/empty



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to