[
https://issues.apache.org/jira/browse/HIVE-26927?focusedWorklogId=838875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838875
]
ASF GitHub Bot logged work on HIVE-26927:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jan/23 15:56
Start Date: 12/Jan/23 15:56
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3937:
URL: https://github.com/apache/hive/pull/3937#discussion_r1068301819
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -533,6 +533,13 @@ public void
executeOperation(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
(AlterTableExecuteSpec.ExpireSnapshotsSpec)
executeSpec.getOperationParams();
icebergTable.expireSnapshots().expireOlderThan(expireSnapshotsSpec.getTimestampMillis()).commit();
break;
+ case SET_CURRENT_SNAPSHOT:
+ AlterTableExecuteSpec.SetCurrentSnapshotSpec setSnapshotVersionSpec =
+ (AlterTableExecuteSpec.SetCurrentSnapshotSpec)
executeSpec.getOperationParams();
+ LOG.info("Executing set current snapshot operation on iceberg table
{}.{} to version {}", hmsTable.getDbName(),
Review Comment:
should it be under debug? All commands would still be logged in Driver
Issue Time Tracking
-------------------
Worklog Id: (was: 838875)
Time Spent: 0.5h (was: 20m)
> Iceberg: Add support for set_current_snapshotid
> -----------------------------------------------
>
> Key: HIVE-26927
> URL: https://issues.apache.org/jira/browse/HIVE-26927
> Project: Hive
> Issue Type: Improvement
> Components: Iceberg integration
> Reporter: Rajesh Balamohan
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, hive supports "rollback" feature. Once rolledback, it is not
> possible to move from older snapshot to newer snapshot.
> It ends up throwing
> {color:#0747a6}"org.apache.iceberg.exceptions.ValidationException: Cannot
> roll back to snapshot, not an ancestor of the current state:" {color}error.
> It will be good to support "set_current_snapshot" function to move to
> different snapshot ids.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
