[
https://issues.apache.org/jira/browse/HIVE-26710?focusedWorklogId=839294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839294
]
ASF GitHub Bot logged work on HIVE-26710:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/23 05:51
Start Date: 16/Jan/23 05:51
Worklog Time Spent: 10m
Work Description: Jinzhengxu commented on code in PR #3735:
URL: https://github.com/apache/hive/pull/3735#discussion_r1070861117
##########
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestThriftObjectInspectors.java:
##########
@@ -150,6 +152,11 @@ public void testThriftSetObjectInspector() throws
Throwable {
assertEquals(Category.STRUCT, oi1.getCategory());
StructObjectInspector soi = (StructObjectInspector) oi1;
List<? extends StructField> fields = soi.getAllStructFieldRefs();
+ Collections.sort(fields, new Comparator<StructField>() {
Review Comment:
Sure, this will make the code more concise and understandable.
Issue Time Tracking
-------------------
Worklog Id: (was: 839294)
Time Spent: 50m (was: 40m)
> Test `testThriftSetObjectInspector` is a flaky test
> ---------------------------------------------------
>
> Key: HIVE-26710
> URL: https://issues.apache.org/jira/browse/HIVE-26710
> Project: Hive
> Issue Type: Improvement
> Environment: Linux 5.4.0-124-generic #140-Ubuntu x86_64 GNU/Linux
>
>
> Reporter: Zhengxu Jin
> Assignee: Zhengxu Jin
> Priority: Trivial
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This test is flaky test. This is because the StructField value uses a
> HashMap, which will cause the test sometimes pass and sometimes fail.
> Run the test with 'NonDex' maven plugin. The command to recreate the flaky
> test failure is
> {code:java}
> mvn -pl serde edu.illinois:nondex-maven-plugin:1.1.2:nondex
> -Dtest=org.apache.hadoop.hive.serde2.objectinspector.TestThriftObjectInspectors#testThriftSetObjectInspector
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
