[
https://issues.apache.org/jira/browse/HIVE-26717?focusedWorklogId=839420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839420
]
ASF GitHub Bot logged work on HIVE-26717:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/23 13:46
Start Date: 16/Jan/23 13:46
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3935:
URL: https://github.com/apache/hive/pull/3935#discussion_r1071264712
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -315,10 +315,14 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
return false;
}
- if (!ci.type.equals(CompactionType.REBALANCE) && ci.numberOfBuckets > 0)
{
- if (LOG.isWarnEnabled()) {
- LOG.warn("Only the REBALANCE compaction accepts the number of
buckets clause (CLUSTERED INTO {N} BUCKETS). " +
- "Since the compaction request is {}, it will be ignored.",
ci.type);
+ boolean insertOnly = AcidUtils.isInsertOnlyTable(table.getParameters());
+ if (LOG.isWarnEnabled() && ci.type.equals(CompactionType.REBALANCE) &&
insertOnly) {
+ LOG.warn("REBALANCE compaction requested on an insert-only table ({}).
Falling back to MAJOR compaction as " +
+ "REBALANCE compaction is supported only on full-acid tables",
table.getTableName());
+ if (ci.numberOfBuckets > 0) {
+ LOG.warn("Only REBALANCE compaction on a full-acid table accepts the
number of buckets clause " +
+ "(CLUSTERED INTO {N} BUCKETS). Since the compaction request is
{} and the table is {}, it will be ignored.",
Review Comment:
why do we need a table type param here as it's only logged when table is
insert only? that is why i was confused with the above if change
Issue Time Tracking
-------------------
Worklog Id: (was: 839420)
Time Spent: 1h 40m (was: 1.5h)
> Query based Rebalance compaction on insert-only tables
> ------------------------------------------------------
>
> Key: HIVE-26717
> URL: https://issues.apache.org/jira/browse/HIVE-26717
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
