[
https://issues.apache.org/jira/browse/HIVE-26704?focusedWorklogId=842594&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842594
]
ASF GitHub Bot logged work on HIVE-26704:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/23 14:11
Start Date: 31/Jan/23 14:11
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3576:
URL: https://github.com/apache/hive/pull/3576#discussion_r1091985114
##########
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java:
##########
@@ -393,6 +397,32 @@ private boolean allowOperationInATransaction(QueryPlan
queryPlan) {
return false;
}
+ @Override
+ public void addWriteIdsToMinHistory(QueryPlan plan, ValidTxnWriteIdList
txnWriteIds) {
+ if (plan.getInputs().isEmpty()) {
+ return;
+ }
+ Map<String, Long> writeIds = plan.getInputs().stream()
+ .filter(input -> !input.isDummy() &&
AcidUtils.isTransactionalTable(input.getTable()))
+ .map(input -> input.getTable().getFullyQualifiedName())
+ .collect(Collectors.toSet()).stream()
Review Comment:
Why do we need to collect as set when its going to be converted to a map
eventually?
Can we write it as this -
`.map(input ->
input.getTable().getFullyQualifiedName()).collect(Collectors.toMap(Function.identity(),
table -> getMinOpenWriteId(txnWriteIds, table)));`
Issue Time Tracking
-------------------
Worklog Id: (was: 842594)
Time Spent: 1h (was: 50m)
> Cleaner shouldn't be blocked by global min open txnId
> -----------------------------------------------------
>
> Key: HIVE-26704
> URL: https://issues.apache.org/jira/browse/HIVE-26704
> Project: Hive
> Issue Type: Task
> Reporter: Denys Kuzmenko
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> *Single transaction blocks cluster-wide Cleaner operations*
> Currently, if there is a single long-running transaction that can prevent the
> Cleaner to clean up any tables. This causes file buildup in tables, which can
> cause performance penalties when listing the directories (note that the
> compaction is not blocked by this, so unnecessary data is not read, but the
> files remain there which causes performance penalty).
> We can reduce the protected files from the open transaction if we have
> query-table correlation data stored in the backend DB, but this change will
> need the current method of recording that detail to be revisited.
> The naive and somewhat backward-compatible approach is to capture the
> minOpenWriteIds per table. It involves a non-mutation operation (as in, there
> is no need for the HMS DB to wait for another user’s operation to record it).
> This does spew data writes into the HMS backend DB, but this is a blind
> insert operation that can be group-committed across many users.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
