[ 
https://issues.apache.org/jira/browse/HIVE-27007?focusedWorklogId=842901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-842901
 ]

ASF GitHub Bot logged work on HIVE-27007:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Feb/23 14:31
            Start Date: 01/Feb/23 14:31
    Worklog Time Spent: 10m 
      Work Description: simhadri-g commented on code in PR #4000:
URL: https://github.com/apache/hive/pull/4000#discussion_r1093299476


##########
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java:
##########
@@ -277,23 +277,31 @@ private static Statistics collectStatistics(HiveConf 
conf, PrunedPartitionList p
     boolean metaTable = table.getMetaTable() != null;
 
     if (!table.isPartitioned()) {
+      long ds, nr, fs;
+      if (table.isNonNative() && 
table.getStorageHandler().canProvideBasicStatistics()) {
+        Map<String, String> icebergBasicStatMap = 
table.getStorageHandler().getBasicStatistics(Partish.buildFor(table));
+        ds = Long.parseLong(icebergBasicStatMap.get("totalSize"));
+        nr = Long.parseLong(icebergBasicStatMap.get("numRows"));
+        fs = Long.parseLong(icebergBasicStatMap.get("numFiles"));

Review Comment:
   Thanks, @kasakrisz , I have updated the PR to catch numberFormatException 
and fall back to the pre-existing implementation of basic stats in case the 
storage handler cannot provide the stats.
   
   Please have a look at the updated PR. 





Issue Time Tracking
-------------------

    Worklog Id:     (was: 842901)
    Time Spent: 2h  (was: 1h 50m)

> Iceberg: Use BasicStats from iceberg table's currrentSnapshot.summary() for 
> query planning
> ------------------------------------------------------------------------------------------
>
>                 Key: HIVE-27007
>                 URL: https://issues.apache.org/jira/browse/HIVE-27007
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Simhadri Govindappa
>            Assignee: Simhadri Govindappa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to