[
https://issues.apache.org/jira/browse/HIVE-27007?focusedWorklogId=843758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843758
]
ASF GitHub Bot logged work on HIVE-27007:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/23 10:05
Start Date: 06/Feb/23 10:05
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #4000:
URL: https://github.com/apache/hive/pull/4000#discussion_r1097173244
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java:
##########
@@ -454,6 +468,27 @@ private static Statistics collectStatistics(HiveConf conf,
PrunedPartitionList p
return stats;
}
+ private static Map<String, Long> getValidBasicStatsFromStorageHandler(Table
table) {
+
+ Map<String, String> storageHandlerBasicStatsMap =
+ (table.isNonNative() &&
table.getStorageHandler().canProvideBasicStatistics()) ?
table.getStorageHandler()
+ .getBasicStatistics(Partish.buildFor(table)) : null;
Review Comment:
How about moving this check and fetch into `BasicStats` and
`StatsUtils.collectStatistics` don't have don't have to be changed at all?
Example:
https://github.com/kasakrisz/hive/commit/e03441477a0c616f1b3012dc4ddc6dfe0f01743b
Issue Time Tracking
-------------------
Worklog Id: (was: 843758)
Time Spent: 4h 10m (was: 4h)
> Iceberg: Use BasicStats from iceberg table's currrentSnapshot.summary() for
> query planning
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-27007
> URL: https://issues.apache.org/jira/browse/HIVE-27007
> Project: Hive
> Issue Type: Improvement
> Reporter: Simhadri Govindappa
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
