[ 
https://issues.apache.org/jira/browse/HIVE-27056?focusedWorklogId=844098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844098
 ]

ASF GitHub Bot logged work on HIVE-27056:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Feb/23 11:50
            Start Date: 07/Feb/23 11:50
    Worklog Time Spent: 10m 
      Work Description: abstractdog opened a new pull request, #4037:
URL: https://github.com/apache/hive/pull/4037

   …r parts of the query
   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
     2. Ensure that you have created an issue on the Hive project JIRA: 
https://issues.apache.org/jira/projects/HIVE/summary
     3. Ensure you have added or run the appropriate tests for your PR: 
     4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., 
'[WIP]HIVE-XXXXX:  Your PR title ...'.
     5. Be sure to keep the PR description updated to reflect all changes.
     6. Please write your PR title to summarize what this PR proposes.
     7. If possible, provide a concise example to reproduce the issue for a 
faster review.
   
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section 
is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster 
reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class 
hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other 
DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description, screenshot and/or a reproducable 
example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Hive versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 844098)
    Remaining Estimate: 0h
            Time Spent: 10m

> Ensure that MR distcp goes to the same Yarn queue as other parts of the query
> -----------------------------------------------------------------------------
>
>                 Key: HIVE-27056
>                 URL: https://issues.apache.org/jira/browse/HIVE-27056
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>             Fix For: 4.0.0-alpha-2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Given the following plan for an EXPORT TABLE query:
> {code}
> +----------------------------------------------------+
> |                      Explain                       |
> +----------------------------------------------------+
> | STAGE DEPENDENCIES:                                |
> |   Stage-2 is a root stage                          |
> |   Stage-3 depends on stages: Stage-2               |
> |   Stage-1 depends on stages: Stage-3               |
> |   Stage-6 depends on stages: Stage-1               |
> |   Stage-5 depends on stages: Stage-6               |
> |   Stage-7 depends on stages: Stage-5               |
> |                                                    |
> | STAGE PLANS:                                       |
> |   Stage: Stage-2                                   |
> |     Tez                                            |
> |       DagId: hive_20230124103803_b865e63c-4565-4b95-8664-8c983938697a:7 |
> |       DagName: hive_20230124103803_b865e63c-4565-4b95-8664-8c983938697a:7 |
> |       Vertices:                                    |
> |         Map 1                                      |
> |             Map Operator Tree:                     |
> |                 TableScan                          |
> |                   alias: distcptest                |
> |                   Statistics: Num rows: 2 Data size: 182658 Basic stats: 
> COMPLETE Column stats: COMPLETE |
> |                   Select Operator                  |
> |                     expressions: id (type: int), txt (type: string) |
> |                     outputColumnNames: _col0, _col1 |
> |                     Statistics: Num rows: 2 Data size: 182658 Basic stats: 
> COMPLETE Column stats: COMPLETE |
> |                     File Output Operator           |
> |                       compressed: false            |
> |                       Statistics: Num rows: 2 Data size: 182658 Basic 
> stats: COMPLETE Column stats: COMPLETE |
> |                       table:                       |
> |                           input format: 
> org.apache.hadoop.hive.ql.io.orc.OrcInputFormat |
> |                           output format: 
> org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat |
> |                           serde: org.apache.hadoop.hive.ql.io.orc.OrcSerde |
> |                           name: 
> bigd35368.distcptest_ced9015c_852b_49a4_8c28_4d284d598523 |
> |             Execution mode: vectorized             |
> |                                                    |
> |   Stage: Stage-3                                   |
> |     Dependency Collection                          |
> |                                                    |
> |   Stage: Stage-1                                   |
> |     Move Operator                                  |
> |       tables:                                      |
> |           replace: false                           |
> |           table:                                   |
> |               input format: org.apache.hadoop.hive.ql.io.orc.OrcInputFormat 
> |
> |               output format: 
> org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat |
> |               serde: org.apache.hadoop.hive.ql.io.orc.OrcSerde |
> |               name: 
> bigd35368.distcptest_ced9015c_852b_49a4_8c28_4d284d598523 |
> |                                                    |
> |   Stage: Stage-6                                   |
> |     Set Properties                                 |
> |       table name: bigd35368.distcptest_ced9015c_852b_49a4_8c28_4d284d598523 
> |
> |       properties:                                  |
> |         transactional true                         |
> |                                                    |
> |   Stage: Stage-5                                   |
> |     Export Work                                    |
> |                                                    |
> |   Stage: Stage-7                                   |
> |     Drop Table                                     |
> |       table: bigd35368.distcptest_ced9015c_852b_49a4_8c28_4d284d598523 |
> |                                                    |
> +----------------------------------------------------+
> {code}
> here, Stage-5 Export Work starts MR distcp jobs
> the problem and solution is described in code comment
> {code}
>   /**
>    * This method ensures if there is an explicit tez.queue.name set, the 
> hadoop shim will submit jobs
>    * to the same yarn queue. This solves a security issue where e.g settings 
> have the following values:
>    * tez.queue.name=sample
>    * hive.server2.tez.queue.access.check=true
>    * In this case, when a query submits Tez DAGs, the tez client layer checks 
> whether the end user has access to
>    * the yarn queue 'sample' via YarnQueueHelper, but this is not respected 
> in case of MR jobs that run
>    * even if the query execution engine is Tez. E.g. an EXPORT TABLE can 
> submit DistCp MR jobs at some stages when
>    * certain criteria are met. We tend to restrict the setting of 
> mapreduce.job.queuename in order to bypass this
>    * security flaw, and even the default queue is unexpected if we explicitly 
> set tez.queue.name.
>    * Under the hood the desired behavior is to have DistCp jobs in the same 
> yarn queue as other parts
>    * of the query. Most of the time, the user isn't aware that a query 
> involves DistCp jobs, hence isn't aware
>    * of these details.
>    */
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to