[ 
https://issues.apache.org/jira/browse/HIVE-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993471#comment-14993471
 ] 

Hive QA commented on HIVE-12310:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12770925/HIVE-12310.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 9774 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver_hbase_queries
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import
org.apache.hadoop.hive.hwi.TestHWISessionManager.testHiveDriver
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5945/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5945/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5945/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12770925 - PreCommit-HIVE-TRUNK-Build

> Update memory estimation login in TopNHash
> ------------------------------------------
>
>                 Key: HIVE-12310
>                 URL: https://issues.apache.org/jira/browse/HIVE-12310
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Thejas M Nair
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-12310.1.patch
>
>
> HIVE-12084 changes TopNHash to use Runtime.getRuntime().freeMemory() for 
> finding available memory.
> However, it does not give the all the memory it could use, it ignores 
> unallocated memory. This is because the heap size of jvm grows up to max heap 
> size (-Xmx) as per it needs. totalMemory() gives total heap space it has 
> allocated, and freeMemory() is the free memory within that.
> See http://i.stack.imgur.com/GjuwM.png and 
> http://stackoverflow.com/questions/3571203/what-is-the-exact-meaning-of-runtime-getruntime-totalmemory-and-freememory
>  .
> So instead of using Runtime.getRuntime().freeMemory() , I think it should use 
> maxMemory() - totalMemory() + freeMemory()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to