[
https://issues.apache.org/jira/browse/HIVE-26735?focusedWorklogId=847816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-847816
]
ASF GitHub Bot logged work on HIVE-26735:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/23 12:35
Start Date: 27/Feb/23 12:35
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #4077:
URL: https://github.com/apache/hive/pull/4077#discussion_r1118677843
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1561,7 +1561,7 @@ public void commitTxn(CommitTxnRequest rqst) throws
NoSuchTxnException, TxnAbort
assert true;
}
- if (txnType != TxnType.READ_ONLY && !isReplayedReplTxn) {
+ if (txnType != TxnType.READ_ONLY && !isReplayedReplTxn && txnType !=
TxnType.COMPACTION && txnType != TxnType.REBALANCE_COMPACTION) {
Review Comment:
qq: Why compaction txn components should not be moved here? Does it handled
by `CompactionTxnHandler` ?
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java:
##########
@@ -237,7 +248,11 @@ String build() {
query.append(" temporary external");
}
if (operation == Operation.INSERT) {
- query.append(" into");
+ if (compactionType.equals(CompactionType.REBALANCE)) {
+ query.append(" overwrite");
+ } else {
+ query.append(" into");
+ }
Review Comment:
`CompactionType.REBALANCE.equals(compactionType)` would be null safe too.
Or equality operator is also fine because `CompactionType` is an enum.
Issue Time Tracking
-------------------
Worklog Id: (was: 847816)
Time Spent: 1.5h (was: 1h 20m)
> Ability to sort the data during rebalancing compaction
> ------------------------------------------------------
>
> Key: HIVE-26735
> URL: https://issues.apache.org/jira/browse/HIVE-26735
> Project: Hive
> Issue Type: Sub-task
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Ability to sort the data during rebalancing compaction
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
