[
https://issues.apache.org/jira/browse/HIVE-15826?focusedWorklogId=848340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848340
]
ASF GitHub Bot logged work on HIVE-15826:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/23 14:01
Start Date: 01/Mar/23 14:01
Worklog Time Spent: 10m
Work Description: abstractdog commented on code in PR #4085:
URL: https://github.com/apache/hive/pull/4085#discussion_r1121778864
##########
ql/src/test/queries/clientpositive/serde_opencsv.q:
##########
@@ -28,9 +29,10 @@ ROW FORMAT SERDE 'org.apache.hadoop.hive.serde2.OpenCSVSerde'
WITH SERDEPROPERTIES(
"separatorChar" = ",",
"quoteChar" = "\'",
- "escapeChar" = "\\"
+ "escapeChar" = "\\",
+ "serialization.encoding" = "ISO8859_1"
) stored as textfile;
LOAD DATA LOCAL INPATH "../../data/files/opencsv-data.txt" INTO TABLE
serde_opencsv;
-SELECT count(*) FROM serde_opencsv;
+SELECT * FROM serde_opencsv;
Review Comment:
was there any purpose of the original count(*) query? without knowing the
history, I believe we can leave both queries here
Issue Time Tracking
-------------------
Worklog Id: (was: 848340)
Time Spent: 1h 20m (was: 1h 10m)
> Add 'serialization.encoding' To All SerDes
> ------------------------------------------
>
> Key: HIVE-15826
> URL: https://issues.apache.org/jira/browse/HIVE-15826
> Project: Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers
> Reporter: David Mollitor
> Assignee: Shailesh Gupta
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-15826.1.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The feature of 'serialization.encoding' has been implemented for the
> following SerDes:
> MultiDelimitSerDe, LazySimpleSerDe
> Please extend this feature to:
> JSON, CSV, and RegexSerDe
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
