[
https://issues.apache.org/jira/browse/HIVE-27019?focusedWorklogId=848881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848881
]
ASF GitHub Bot logged work on HIVE-27019:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/23 09:23
Start Date: 03/Mar/23 09:23
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4032:
URL: https://github.com/apache/hive/pull/4032#discussion_r1124208770
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java:
##########
@@ -97,16 +90,11 @@ public void init(AtomicBoolean stop) throws Exception {
}
@Override List<Partition> getPartitionsByNames(CompactionInfo ci) throws
MetaException {
- try {
- return getMSForConf(conf).getPartitionsByNames(getDefaultCatalog(conf),
ci.dbname, ci.tableName,
- Collections.singletonList(ci.partName));
- } catch (MetaException e) {
- LOG.error("Unable to get partitions by name for CompactionInfo=" + ci);
- throw e;
- } catch (NoSuchObjectException e) {
- LOG.error("Unable to get partitions by name for CompactionInfo=" + ci);
- throw new MetaException(e.toString());
- }
+ return CompactorUtil.getPartitionsByNames(conf, ci.dbname, ci.tableName,
ci.partName);
+ }
+
+ public boolean isCacheEnabled() {
Review Comment:
shouldn't it be abstract?
Issue Time Tracking
-------------------
Worklog Id: (was: 848881)
Time Spent: 18.5h (was: 18h 20m)
> Split Cleaner into separate manageable modular entities
> -------------------------------------------------------
>
> Key: HIVE-27019
> URL: https://issues.apache.org/jira/browse/HIVE-27019
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 18.5h
> Remaining Estimate: 0h
>
> As described by the parent task -
> Cleaner can be divided into separate entities like -
> *1) Handler* - This entity fetches the data from the metastore DB from
> relevant tables and converts it into a request entity called CleaningRequest.
> It would also do SQL operations post cleanup (postprocess). Every type of
> cleaning request is provided by a separate handler.
> *2) Filesystem remover* - This entity fetches the cleaning requests from
> various handlers and deletes them according to the cleaning request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
