[
https://issues.apache.org/jira/browse/HIVE-27117?focusedWorklogId=849308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-849308
]
ASF GitHub Bot logged work on HIVE-27117:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/23 15:12
Start Date: 06/Mar/23 15:12
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #4096:
URL: https://github.com/apache/hive/pull/4096#discussion_r1126568905
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -577,7 +577,7 @@ public RawStore getMS() throws MetaException {
return getMSForConf(conf);
}
- public static RawStore getMSForConf(Configuration conf) throws MetaException
{
+ public static synchronized RawStore getMSForConf(Configuration conf) throws
MetaException {
Review Comment:
This is another flakyness. Without this,
org.apache.hadoop.hive.ql.txn.compactor.TestCompactionMetrics.testInitiatorFailuresCountedCorrectly
deadlocked repeatedly on my machine. 4 threads were trying to init the DB (and
get the RawStore) concurrently at the smae time which resulted in a deadlock.
Issue Time Tracking
-------------------
Worklog Id: (was: 849308)
Time Spent: 1h 50m (was: 1h 40m)
> Fix compaction related flaky tests
> ----------------------------------
>
> Key: HIVE-27117
> URL: https://issues.apache.org/jira/browse/HIVE-27117
> Project: Hive
> Issue Type: Task
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The following tests turned out to be flaky recently:
> *
> org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testDropTableAndCompactionConcurrent
> *
> org.apache.hadoop.hive.ql.txn.compactor.TestCompactionMetrics.testInitiatorFailuresCountedCorrectly
> *
> org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testMajorCompactionNotPartitionedWithoutBuckets
> *
> org.apache.hadoop.hive.ql.txn.compactor.TestCrudCompactorOnTez.testCompactionWithCreateTableProps
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
