[
https://issues.apache.org/jira/browse/HIVE-27097?focusedWorklogId=851619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-851619
]
ASF GitHub Bot logged work on HIVE-27097:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/23 22:04
Start Date: 18/Mar/23 22:04
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #4076:
URL: https://github.com/apache/hive/pull/4076#discussion_r1141188608
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java:
##########
@@ -227,6 +231,26 @@ public Result invokeInternal(final Object proxy, final
Method method, final Obje
}
}
+ private Class<SQLException>[] unrecoverableSqlExceptions = new Class[]{
+ // TODO: collect more unrecoverable SQLExceptions
+ SQLIntegrityConstraintViolationException.class
+ };
+
+ private boolean isRecoverableException(Throwable t) {
+ assert t != null && (t instanceof JDOException || t instanceof
NucleusException);
Review Comment:
note, that assertions won't get executed unless you enable them explicitly
`-enableassertions` (-ea)
Issue Time Tracking
-------------------
Worklog Id: (was: 851619)
Time Spent: 1h 40m (was: 1.5h)
> Improve the retry strategy for Metastore client and server
> ----------------------------------------------------------
>
> Key: HIVE-27097
> URL: https://issues.apache.org/jira/browse/HIVE-27097
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 4.0.0-alpha-2
> Reporter: Wechar
> Assignee: Wechar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> *Background*
> Hive provides *{{RetryingMetaStoreClient}}* and *{{RetryingHMSHandler}}* to
> do retry when thrift request failed:
> * RetryingMetaStoreClient will retry for *thrift related exception* and some
> *MetaException*
> * RetryingHMSHandler will retry for all {*}JDOException{*} or
> *NucleusException*.
> *Motivation*
> Current retry mechanism will lead to many unnecessary retries in both client
> and server. To simplify the process, we introduce following retry mechanism:
> * Client side only concerns the error of communication, i.e.,
> {*}TTransportException{*}.
> * Server side can skip some exceptions which always turn to fail even with
> retry, like {*}SQLIntegrityConstraintViolationException{*}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
