[
https://issues.apache.org/jira/browse/HIVE-27150?focusedWorklogId=853387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853387
]
ASF GitHub Bot logged work on HIVE-27150:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/23 11:43
Start Date: 28/Mar/23 11:43
Worklog Time Spent: 10m
Work Description: VenuReddy2103 commented on code in PR #4123:
URL: https://github.com/apache/hive/pull/4123#discussion_r1150463962
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java:
##########
@@ -459,16 +459,15 @@ boolean doesPartitionExist(String catName, String dbName,
String tableName,
* @param catName catalog name.
* @param dbName database name.
* @param tableName table name.
- * @param part_vals list of partition values.
+ * @param partName partition name.
* @return true if the partition was dropped.
* @throws MetaException Error accessing the RDBMS.
* @throws NoSuchObjectException no partition matching this description
exists
* @throws InvalidObjectException error dropping the statistics for the
partition
* @throws InvalidInputException error dropping the statistics for the
partition
*/
- boolean dropPartition(String catName, String dbName, String tableName,
- List<String> part_vals) throws MetaException, NoSuchObjectException,
InvalidObjectException,
- InvalidInputException;
+ boolean dropPartition(String catName, String dbName, String tableName,
String partName)
Review Comment:
IMHO, Instead of defining this new API, we can make the partname inside the
existing `dropPartition()` method itself to invoke `dropPartitionsInternal()`
or `dropPartitions()`. Because the new API signature is similar to exisiting
`dropPartitions()` except the last argument(i.e., single partname vs list of
partnames). May be, we can mark `dropPartition()` as deprecated and insist
using `dropPartitions()` directly in future.
Issue Time Tracking
-------------------
Worklog Id: (was: 853387)
Time Spent: 1h 50m (was: 1h 40m)
> Drop single partition can also support direct sql
> -------------------------------------------------
>
> Key: HIVE-27150
> URL: https://issues.apache.org/jira/browse/HIVE-27150
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Wechar
> Assignee: Wechar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> *Background:*
> [HIVE-6980|https://issues.apache.org/jira/browse/HIVE-6980] supports direct
> sql for drop_partitions, we can reuse this huge improvement in drop_partition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
