[
https://issues.apache.org/jira/browse/HIVE-27179?focusedWorklogId=853828&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853828
]
ASF GitHub Bot logged work on HIVE-27179:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/23 04:49
Start Date: 30/Mar/23 04:49
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #4164:
URL: https://github.com/apache/hive/pull/4164#discussion_r1152729260
##########
service/src/java/org/apache/hive/service/server/HiveServer2.java:
##########
@@ -133,6 +133,8 @@
import com.google.common.util.concurrent.SettableFuture;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
+import javax.servlet.jsp.JspFactory;
Review Comment:
Hi @saihemanth-cloudera, the jetty-runner jar contains the classes:
```
[Loaded javax.servlet.jsp.JspFactory from
file:/opt/xxx/jetty-runner-9.4.48.v20220622.jar]
[Loaded javax.servlet.jsp.JspContext from
file:/opt/xxx/jetty-runner-9.4.48.v20220622.jar]
[Loaded javax.servlet.jsp.PageContext from
file:/opt/xxx/jetty-runner-9.4.48.v20220622.jar]
```
In fact this is where the class conflict happens.
Issue Time Tracking
-------------------
Worklog Id: (was: 853828)
Time Spent: 50m (was: 40m)
> HS2 WebUI throws NPE when JspFactory loaded from jetty-runner
> -------------------------------------------------------------
>
> Key: HIVE-27179
> URL: https://issues.apache.org/jira/browse/HIVE-27179
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In HIVE-17088{*},{*} we resolved a NPE thrown from HS2 WebUI by introducing
> javax.servlet.jsp-api. It works as expected when the javax.servlet.jsp-api
> jar prevails jetty-runner jar, but things can be different in some
> environments, it still throws NPE when opening the HS2 web:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hive.generated.hiveserver2.hiveserver2_jsp._jspService(hiveserver2_jsp.java:286)
>
> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:71)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
> at
> org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1443)
>
> at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:791)
> at
> org.eclipse.jetty.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1626)
> ...{noformat}
> The jetty-runner JspFactory.getDefaultFactory() just returns null.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
