[
https://issues.apache.org/jira/browse/HIVE-22383?focusedWorklogId=854021&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854021
]
ASF GitHub Bot logged work on HIVE-22383:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/23 22:33
Start Date: 30/Mar/23 22:33
Worklog Time Spent: 10m
Work Description: rbalamohan commented on code in PR #4161:
URL: https://github.com/apache/hive/pull/4161#discussion_r1153852107
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -2929,10 +2929,10 @@ private void setStatsPropAndAlterPartition(boolean
resetStatistics, Table tbl,
}
private void setStatsPropAndAlterPartitions(boolean resetStatistics, Table
tbl,
- List<Partition> partitions,
+ List<Partition> partitions,
Review Comment:
I believe this change is unintentional. Can you remove this change?
Rest LGTM.
Issue Time Tracking
-------------------
Worklog Id: (was: 854021)
Time Spent: 1h 10m (was: 1h)
> `alterPartitions` is invoked twice during dynamic partition load causing
> runtime delay
> --------------------------------------------------------------------------------------
>
> Key: HIVE-22383
> URL: https://issues.apache.org/jira/browse/HIVE-22383
> Project: Hive
> Issue Type: Bug
> Reporter: Rajesh Balamohan
> Assignee: Dmitriy Fingerman
> Priority: Major
> Labels: performance, pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> First invocation in {{Hive::loadDynamicPartitions}}
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2978
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2638
> Second invocation in {{BasicStatsTask::aggregateStats}}
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java#L335
> This leads to good amount of delay in dynamic partition loading.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
