[
https://issues.apache.org/jira/browse/HIVE-27185?focusedWorklogId=854148&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854148
]
ASF GitHub Bot logged work on HIVE-27185:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/23 10:42
Start Date: 31/Mar/23 10:42
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #4165:
URL: https://github.com/apache/hive/pull/4165#discussion_r1154319629
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java:
##########
@@ -52,12 +52,13 @@ private IcebergTableUtil() {
* Constructs the table properties needed for the Iceberg table loading by
retrieving the information from the
* hmsTable. It then calls {@link IcebergTableUtil#getTable(Configuration,
Properties)} with these properties.
* @param configuration a Hadoop configuration
- * @param hmsTable the HMS table
- * @param skipCache if set to true there won't be an attempt to retrieve the
table from SessionState
+ * @param hmsTable the HMS table
+ * @param skipCache if set to true there won't be an attempt to retrieve
the table from SessionState
+ * @param suffix the suffix to use for cache.
* @return the Iceberg table
*/
static Table getTable(Configuration configuration,
org.apache.hadoop.hive.metastore.api.Table hmsTable,
- boolean skipCache) {
+ boolean skipCache, String suffix) {
Review Comment:
I changed the approach, if it is write operation where the rows affected
gets changed, I read from the Cache, if not do the same what we do today.
Give a check, if that sounds cool, or if you feel if it that can also cause
some issues,
Issue Time Tracking
-------------------
Worklog Id: (was: 854148)
Time Spent: 1h 50m (was: 1h 40m)
> Iceberg: Cache iceberg table while loading for stats
> ----------------------------------------------------
>
> Key: HIVE-27185
> URL: https://issues.apache.org/jira/browse/HIVE-27185
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Presently iceberg for stats loads the iceberg table multiple times for stats
> via different routes.
> Cache it to avoid reading/loading the iceberg table multiple times.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
