[
https://issues.apache.org/jira/browse/HIVE-26659?focusedWorklogId=854396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854396
]
ASF GitHub Bot logged work on HIVE-26659:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/23 05:06
Start Date: 03/Apr/23 05:06
Worklog Time Spent: 10m
Work Description: ngsg opened a new pull request, #4190:
URL: https://github.com/apache/hive/pull/4190
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Proceed MapJoin operation with empty storage if that storage is RHS table of
AntiJoin.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Current MapJoinOperator does not join empty RowContainers unless it has any
OuterJoin.
Therefore, MapJoinOperator always produces no rows for AntiJoin as it joins
non-empty LHS RowContainer and empty RHS RowContainer.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
I add a qfile test that does not use vectorized MapJoin operator.
I also ran all TPC-DS queries on 1TB dataset with
hive.auto.convert.anti.join=true and checked that all queries returns the
correct result.
Issue Time Tracking
-------------------
Worklog Id: (was: 854396)
Remaining Estimate: 0h
Time Spent: 10m
> TPC-DS query 16, 69, 94 return wrong results.
> ---------------------------------------------
>
> Key: HIVE-26659
> URL: https://issues.apache.org/jira/browse/HIVE-26659
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 4.0.0-alpha-2
> Reporter: Sungwoo Park
> Assignee: Seonggon Namgung
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> TPC-DS query 16, 69, 94 return wrong results when hive.auto.convert.anti.join
> is set to true.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
