[ 
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=854461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854461
 ]

ASF GitHub Bot logged work on HIVE-26809:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Apr/23 09:09
            Start Date: 03/Apr/23 09:09
    Worklog Time Spent: 10m 
      Work Description: abstractdog commented on code in PR #4121:
URL: https://github.com/apache/hive/pull/4121#discussion_r1155690043


##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -298,11 +300,11 @@ public void seek(PositionProvider index) throws 
IOException {
       }
     }
 
-    @Override
+    @Override        
     public void nextVector(
-        ColumnVector previousVector, boolean[] isNull, int batchSize) throws 
IOException {
+        ColumnVector previousVector, boolean[] isNull, int batchSize, 
FilterContext filterContext, TypeReader.ReadPhase readPhase) throws IOException 
{

Review Comment:
   this line looks a bit long :) can you reformat according to 
[this](https://github.com/apache/hive/blob/master/dev-support/eclipse-styles.xml)?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 854461)
    Time Spent: 9h 20m  (was: 9h 10m)

> Upgrade ORC to 1.8.3
> --------------------
>
>                 Key: HIVE-26809
>                 URL: https://issues.apache.org/jira/browse/HIVE-26809
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: Dmitriy Fingerman
>            Assignee: Zoltán Rátkai
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 9h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to