[
https://issues.apache.org/jira/browse/HIVE-26984?focusedWorklogId=854757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854757
]
ASF GitHub Bot logged work on HIVE-26984:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/23 10:59
Start Date: 04/Apr/23 10:59
Worklog Time Spent: 10m
Work Description: abstractdog commented on PR #3983:
URL: https://github.com/apache/hive/pull/3983#issuecomment-1495767703
@TuroczyX : actually deprecating some constructors is just a prerequisite
for HIVE-26985, which I'm discovering to be solved with AspectJ, so this change
is not urgent anymore
in general, hiding public constructor might make sense in some
circumstances, but now I'm going a different way, so it's not a big deal if we
don't ship this in 4.0
Issue Time Tracking
-------------------
Worklog Id: (was: 854757)
Time Spent: 2h (was: 1h 50m)
> Deprecate public HiveConf constructors
> --------------------------------------
>
> Key: HIVE-26984
> URL: https://issues.apache.org/jira/browse/HIVE-26984
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> From time to time we investigate configuration object problems that are hard
> to investigate. We can improve this area, e.g. with HIVE-26985, but first, we
> need to introduce a public static factory method to hook into the creation
> process. I can see this pattern in another projects as well, like:
> HBaseConfiguration.
> Creating custom HiveConf subclasses can be useful because putting optional
> (say: if else branches or whatever) stuff into the original HiveConf object's
> hot codepaths can turn it less performant instantly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
