[ 
https://issues.apache.org/jira/browse/HIVE-27187?focusedWorklogId=854782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854782
 ]

ASF GitHub Bot logged work on HIVE-27187:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/23 12:36
            Start Date: 04/Apr/23 12:36
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4166:
URL: https://github.com/apache/hive/pull/4166#discussion_r1157183277


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/NonNativeMaterializedViewASTBuilder.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.ddl.view.materialized.alter.rebuild;
+
+import org.apache.hadoop.hive.ql.Context;
+import org.apache.hadoop.hive.ql.metadata.Table;
+import org.apache.hadoop.hive.ql.metadata.VirtualColumn;
+import org.apache.hadoop.hive.ql.parse.ASTNode;
+
+import java.util.List;
+import java.util.stream.Collectors;
+
+import static java.util.Collections.singletonList;
+
+public class NonNativeMaterializedViewASTBuilder extends 
MaterializedViewASTBuilder {

Review Comment:
   what about FullAcidMaterializedViewASTBuilder? Should it be 
`NativeAcidMaterializedViewASTBuilder`?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 854782)
    Time Spent: 2h 40m  (was: 2.5h)

> Incremental rebuild of materialized view having aggregate and stored by 
> iceberg
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-27187
>                 URL: https://issues.apache.org/jira/browse/HIVE-27187
>             Project: Hive
>          Issue Type: Improvement
>          Components: Iceberg integration, Materialized views
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently incremental rebuild of materialized view stored by iceberg which 
> definition query contains aggregate operator is transformed to an insert 
> overwrite statement which contains a union operator if the source tables 
> contains insert operations only. One branch of the union scans the view the 
> other produces the delta.
> This can be improved further: transform the statement to a multi insert 
> statement representing a merge statement to insert new aggregations and 
> update existing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to