[ 
https://issues.apache.org/jira/browse/HIVE-27208?focusedWorklogId=854834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854834
 ]

ASF GitHub Bot logged work on HIVE-27208:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/23 15:28
            Start Date: 04/Apr/23 15:28
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4185:
URL: https://github.com/apache/hive/pull/4185#discussion_r1157427849


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java:
##########
@@ -253,11 +253,13 @@ public void alterTable(RawStore msdb, Warehouse wh, 
String catName, String dbnam
       boolean renamedTranslatedToExternalTable = rename && 
MetaStoreUtils.isTranslatedToExternalTable(oldt)
           && MetaStoreUtils.isTranslatedToExternalTable(newt);
 
+      boolean isRenameIcebergTable = rename && 
"ICEBERG".equalsIgnoreCase(newt.getParameters().get("table_type"));

Review Comment:
   could we please introduce an enum for the table type





Issue Time Tracking
-------------------

    Worklog Id:     (was: 854834)
    Time Spent: 2h 20m  (was: 2h 10m)

> Iceberg: Add support for rename table
> -------------------------------------
>
>                 Key: HIVE-27208
>                 URL: https://issues.apache.org/jira/browse/HIVE-27208
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Add support for renaming iceberg tables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to